Skip to content

Generate proper constructor for classes with smart pointer#17428

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
asmorkalov:as/java_smart_constructors
May 29, 2020
Merged

Generate proper constructor for classes with smart pointer#17428
opencv-pushbot merged 1 commit intoopencv:3.4from
asmorkalov:as/java_smart_constructors

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented May 29, 2020 •
edited
Loading

Issue: #11268

Affected classes in 3.4:

  • BOWKMeansTrainer
  • FlannBasedMatcher
  • BFMatcher

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added bug test category: java bindings Hackathon https://opencv.org/opencv-hackathon-starts-next-week/ labels May 29, 2020
@asmorkalov asmorkalov changed the base branch from master to 3.4 May 29, 2020 13:41
alalek
alalek approved these changes May 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit c6b60e2 into opencv:3.4 May 29, 2020
@alalek alalek mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: java bindings Hackathon https://opencv.org/opencv-hackathon-starts-next-week/ test

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

Mixed raw pointers and Ptr<> in features2d java wrappers

3 participants

@asmorkalov @alalek @opencv-pushbot