Skip to content

Enable stateful kernels in G-API OCV Backend#17350

Merged
alalek merged 1 commit intoopencv:masterfrom
AsyaPronina:gapi_ocv_stateful_kernel
Jun 4, 2020
Merged

Enable stateful kernels in G-API OCV Backend#17350
alalek merged 1 commit intoopencv:masterfrom
AsyaPronina:gapi_ocv_stateful_kernel

Conversation

@AsyaPronina
Copy link
Copy Markdown
Contributor

@AsyaPronina AsyaPronina commented May 22, 2020 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
buildworker:iOS=macosx-2

force_builders=ARMv7,Custom
build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

dmatveev
dmatveev reviewed May 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also test your stateful kernels with real streaming.

@AsyaPronina
Copy link
Copy Markdown
Contributor Author

AsyaPronina commented May 28, 2020

Hi Dmitry, Anatoly (@dmatveev @TolyaTalamanov), could you please check the updates?

@AsyaPronina AsyaPronina requested a review from dmatveev May 28, 2020 17:52
dmatveev
dmatveev reviewed May 28, 2020
View reviewed changes
dmatveev
dmatveev reviewed May 29, 2020
View reviewed changes
@AsyaPronina
Copy link
Copy Markdown
Contributor Author

AsyaPronina commented May 29, 2020

Hi Dmitry (@dmatveev), I've fixed all comments, could you please check the updates?

@AsyaPronina AsyaPronina requested a review from dmatveev May 29, 2020 18:51
TolyaTalamanov
TolyaTalamanov reviewed Jun 2, 2020
View reviewed changes
modules/gapi/test/cpu/gapi_ocv_stateful_kernel_test_utils.hpp Outdated
{
template<typename T> struct get_first_param;
template<typename R, typename P1> struct get_first_param<R(P1)> {
typedef P1 type;
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using ?

Copy link
Copy Markdown
Contributor Author

@AsyaPronina AsyaPronina Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

dmatveev
dmatveev reviewed Jun 3, 2020
View reviewed changes
dmatveev
dmatveev reviewed Jun 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost..

@AsyaPronina AsyaPronina force-pushed the gapi_ocv_stateful_kernel branch 2 times, most recently from db616f3 to f2c7250 Compare June 4, 2020 17:10
@AsyaPronina AsyaPronina requested a review from dmatveev June 4, 2020 17:11
@AsyaPronina AsyaPronina force-pushed the gapi_ocv_stateful_kernel branch 2 times, most recently from 7664689 to 20bcafb Compare June 4, 2020 18:10
@AsyaPronina AsyaPronina force-pushed the gapi_ocv_stateful_kernel branch from 20bcafb to b083c20 Compare June 4, 2020 19:16
dmatveev
dmatveev approved these changes Jun 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 well done! Thanks!

@alalek alalek merged commit 7d30e19 into opencv:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@TolyaTalamanov TolyaTalamanov Awaiting requested review from TolyaTalamanov

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@AsyaPronina @dmatveev @TolyaTalamanov @anton-potapov @alalek