Skip to content

Added information to OpenCV documentation [MacOS]#17341

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
hunter-college-ossd-spr-2020:3.4-1
Jun 12, 2020
Merged

Added information to OpenCV documentation [MacOS]#17341
opencv-pushbot merged 1 commit intoopencv:3.4from
hunter-college-ossd-spr-2020:3.4-1

Conversation

@wongjessica
Copy link
Copy Markdown
Contributor

@wongjessica wongjessica commented May 21, 2020

Closes #17340

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [ ✓ ] I agree to contribute to the project under OpenCV (BSD) License.
  • [ ✓ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • [ ✓ ] The PR is proposed to proper branch
  • [ ✓ ] There is reference to original bug report and related work
  • [ ✓ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [ ✓ ] The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented May 21, 2020

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@wongjessica wongjessica changed the base branch from master to 3.4 May 21, 2020 14:35
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 25, 2020

@wongjessica Please pay attention on PR commits history. The branch is still based on master.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 2, 2020

@wongjessica Friendly reminder.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 8, 2020

@wongjessica Do you have a chance to rebase the PR properly?

@wongjessica @boubascript
Added information to OpenCV documentation [MacOS]
0417c8c 
Added and Edited specific information to the "Installation in MacOS" OpenCV documentation.
Closes opencv#17340
@wongjessica
Copy link
Copy Markdown
Contributor Author

wongjessica commented Jun 12, 2020

Hello @asmorkalov With the help of my friend, it should be fixed!

alalek
alalek approved these changes Jun 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit 0c8da03 into opencv:3.4 Jun 12, 2020
@alalek alalek mentioned this pull request Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

Add and Edit specific information to the "Installation in MacOS" OpenCV documentation

4 participants

@wongjessica @alalek @asmorkalov @opencv-pushbot