Skip to content

Fixed NMSBoxes bug#17332

Merged
alalek merged 5 commits intoopencv:3.4from
l-bat:fix_nms
May 25, 2020
Merged

Fixed NMSBoxes bug#17332
alalek merged 5 commits intoopencv:3.4from
l-bat:fix_nms

Conversation

@l-bat
Copy link
Copy Markdown
Contributor

@l-bat l-bat commented May 20, 2020 •
edited
Loading

Pull Request Readiness Checklist

resolves: #17246, #17111

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
Hypothesis: NMS over multiple output layers is not needed (i.e. YOLOv3, YOLOv4)

Hypothesis: NMS over multiple output layers is not needed (i.e. YOLOv3, YOLOv4)
Resuls: NMS is required

Output without NMS in sample - 10 detections. Some of detections have an IoU approximately equal 1.
no_nms

Output with NMS in sample - 7 detections.
nms

@l-bat l-bat added this to the 3.4.11 milestone May 20, 2020
@l-bat l-bat linked an issue May 20, 2020 that may be closed by this pull request
Using opencv to call the darknet version of yolo results are inconsistent #17111
Closed
dkurt
dkurt reviewed May 20, 2020
View reviewed changes
dkurt
dkurt reviewed May 20, 2020
View reviewed changes
dkurt
dkurt reviewed May 20, 2020
View reviewed changes
@dkurt
Copy link
Copy Markdown
Member

dkurt commented May 20, 2020

Please modify C++ sample as well.

dkurt
dkurt reviewed May 21, 2020
View reviewed changes
dkurt
dkurt reviewed May 21, 2020
View reviewed changes
dkurt
dkurt reviewed May 22, 2020
View reviewed changes
dkurt
dkurt reviewed May 22, 2020
View reviewed changes
@l-bat l-bat force-pushed the fix_nms branch 2 times, most recently from 7c76232 to 82dce6f Compare May 25, 2020 09:30
dkurt
dkurt approved these changes May 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks! Please also open a separate PR to master branch with similar fix for cv::dnn::DetectionModel

@dkurt dkurt self-assigned this May 25, 2020
@alalek alalek merged commit d5e8792 into opencv:3.4 May 25, 2020
@l-bat l-bat mentioned this pull request May 25, 2020
Merged
6 tasks
@dkurt dkurt linked an issue May 26, 2020 that may be closed by this pull request
cv::dnn::NMSBoxes bug #17246
Closed
@dkurt dkurt mentioned this pull request May 28, 2020
Closed
4 tasks
@alalek alalek mentioned this pull request May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

bug category: dnn category: samples

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

cv::dnn::NMSBoxes bug Using opencv to call the darknet version of yolo results are inconsistent

3 participants

@l-bat @dkurt @alalek