Revise and expand kNN Python tutorials#17313
Merged
alalek merged 2 commits intoopencv:3.4from May 18, 2020
Merged
Conversation
Contributor
Author
|
Just committed again to correct the broken NPTEL link I had missed earlier. I can, of course, squash the commits if approved, but was not sure if this had already been seen and wanted to make the additional change clear. |
Member
It is better to avoid starting a new large sentence in the middle of the line. Markdown format merges lines into a single paragraph (empty dedicated line is required to start new paragraph). |
Contributor
Author
|
@alalek Ah that makes sense - thank you very much for the explanation and for accepting the pr! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request covers a number of revisions and small additions to the kNN tutorials for OpenCV-Python. I would be very happy to do the same for the other Python ML tutorials!
Please note that I am not sure why some sentences were split across multiple lines. While it does not seem to reflect on Github, this can be seen by viewing the original unaltered files (and other ML tutorials) in VSCode and Vim.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.