Important single character fix#17299
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from May 15, 2020
Merged
Conversation
Member
|
Thank you for catching this! This patch should go into 3.4 branch first. So, please:
Note: no needs to re-open PR, apply changes "inplace". |
Contributor
Author
|
done i guess. |
Contributor
|
Looks like rebase goes wrong... Try the following: git checkout patch-1 -B patch-1-backup
git fetch https://github.com/opencv/opencv 3.4:3.4
git checkout 3.4 -B patch-1
git cherry-pick 9b9aa3d
git push -f origin patch-1:patch-1
git branch -D patch-1-backup |
Contributor
Author
|
:D |
mshabunin
approved these changes
May 15, 2020
Contributor
Author
|
without this patch i wonder what would be |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.