Skip to content

Increase test threshold for YOLOv3 on OCL FP16#17297

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:dnn_yolov3_ocl
May 18, 2020
Merged

Increase test threshold for YOLOv3 on OCL FP16#17297
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:dnn_yolov3_ocl

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented May 14, 2020 •
edited by alalek
Loading 

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.1.0:16.04
#build_image:Custom=ubuntu-openvino-2019r3.0:16.04
build_image:Custom Win=openvino-2020.2.0
build_image:Custom Mac=openvino-2020.2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*YOLO*

@dkurt dkurt linked an issue May 14, 2020 that may be closed by this pull request
OpenCV 4.1.2 cv2.dnn.DNN_BACKEND_INFERENCE_ENGINE cv2.dnn.DNN_TARGET_OPENCL #16043
Closed
@alalek
Copy link
Copy Markdown
Member

alalek commented May 15, 2020

@dkurt Could you please take a look on OpenCL failures from Custom builder?

@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented May 15, 2020

@alalek, thanks! Added skip for DLIE/OCL and batch size > 1. DLIE/OCL_FP16 works fine

@dkurt dkurt force-pushed the dnn_yolov3_ocl branch from 438fa7c to bcdc1a5 Compare May 15, 2020 19:54
alalek
alalek reviewed May 18, 2020
View reviewed changes
modules/dnn/test/test_darknet_importer.cpp Outdated
if ((INF_ENGINE_VER_MAJOR_LE(2018050000) || INF_ENGINE_VER_MAJOR_GE(2020020000)) &&
target == DNN_TARGET_OPENCL)
applyTestTag(CV_TEST_TAG_DNN_SKIP_IE_OPENCL, CV_TEST_TAG_DNN_SKIP_IE_VERSION);
else if (INF_ENGINE_VER_MAJOR_EQ(2019020000))
Copy link
Copy Markdown
Member

@alalek alalek May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INF_ENGINE_VER_MAJOR_GE(2020020000)
else if (INF_ENGINE_VER_MAJOR_EQ(2019020000))

This code path should be updated too.

Also there are failed tests with OV 2019R3 and 2020.1

Copy link
Copy Markdown
Member Author

@dkurt dkurt May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me we can skip DNN_TARGET_OPENCL for all the versions and DNN_TARGET_OPENCL_FP16 for <= 2020.1

Copy link
Copy Markdown
Member

@alalek alalek May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkurt Please check code compilation.

Copy link
Copy Markdown
Member Author

@dkurt dkurt May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, fixed that!

@dkurt dkurt force-pushed the dnn_yolov3_ocl branch from bcdc1a5 to 2fad0ad Compare May 18, 2020 13:17
@dkurt dkurt force-pushed the dnn_yolov3_ocl branch from 2fad0ad to b5035ce Compare May 18, 2020 16:07
alalek
alalek approved these changes May 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 322960f into opencv:3.4 May 18, 2020
@alalek alalek mentioned this pull request May 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: dnn test

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

OpenCV 4.1.2 cv2.dnn.DNN_BACKEND_INFERENCE_ENGINE cv2.dnn.DNN_TARGET_OPENCL

3 participants

@dkurt @alalek @opencv-pushbot