Implementation of colormap "DeepGreen"#17260
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from May 12, 2020
jsxyhelu:add_deepgreen_colormap
Merged
Implementation of colormap "DeepGreen"#17260opencv-pushbot merged 1 commit intoopencv:3.4from jsxyhelu:add_deepgreen_colormap
opencv-pushbot merged 1 commit intoopencv:3.4from
jsxyhelu:add_deepgreen_colormap
Conversation
Contributor
|
Thanks for the contribution. Could you add some tests for the new feature or extend the existing one? |
Contributor
Author
|
@asmorkalov This pullrequest hase been changed。 |
alalek
approved these changes
May 12, 2020
Member
alalek
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for contribution 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
from #17254
I need to implement the "false color" transformation of the green theme. Of the templates currently provided, only COLORMAP_SUMMER is the closest, but its color is too light and does not look very clear,in my opinion. So I combined the two existing templates of COLORMAP_OCEAN and COLORMAP_SUMMER to build a new colormap "DeepGreen". It can achieve significant pseudo-color transformation of the green theme.
Also, I add cv::COLORMAP_DEEPGREEN as the flag of cv::applyColorMap.
I checked this feature using the following code.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.