Skip to content

Update Image Watch Tutorial#17235

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
R-penguins:patch-1
May 10, 2020
Merged

Update Image Watch Tutorial#17235
opencv-pushbot merged 1 commit intoopencv:3.4from
R-penguins:patch-1

Conversation

@R-penguins
Copy link
Copy Markdown
Contributor

@R-penguins R-penguins commented May 7, 2020

Updated the Windows Visual Studio Image Watch tutorial to include download links to the latest versions for the latest Visual Studio versions.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: documentation Documentation fix or update platform: win32 labels May 8, 2020
@asmorkalov asmorkalov self-requested a review May 8, 2020 08:42
asmorkalov
asmorkalov approved these changes May 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alalek
Copy link
Copy Markdown
Member

alalek commented May 8, 2020

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@R-penguins R-penguins changed the base branch from master to 3.4 May 9, 2020 23:56
@R-penguins
Update Image Watch Tutorial
b43da8a 
Updated the Windows Visual Studio Image Watch tutorial to include download links to the latest versions of Visual Studio Image Watch for newer Visual Studio versions.
@opencv-pushbot opencv-pushbot merged commit fd06139 into opencv:3.4 May 10, 2020
@R-penguins R-penguins deleted the patch-1 branch May 10, 2020 14:53
@alalek alalek mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update platform: win32

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

4 participants

@R-penguins @alalek @asmorkalov @opencv-pushbot