Skip to content

Update table of content for imgproc module tutorials to reflect languages used#17223

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
hunter-college-ossd-spr-2020:imgproc-toc
May 7, 2020
Merged

Update table of content for imgproc module tutorials to reflect languages used#17223
opencv-pushbot merged 1 commit intoopencv:3.4from
hunter-college-ossd-spr-2020:imgproc-toc

Conversation

@dmallia17
Copy link
Copy Markdown
Contributor

This adds the Languages field for the "Random generator and text with OpenCV" tutorial and updates the Languages field for the "Anisotropic image segmentation by a gradient structure tensor" tutorial.

On a related note: I have not been able to locate an equivalent for the C++ RNG class in Python, but I believe this functionality can be achieved with NumPy (among other options). If I have missed the equivalent or if NumPy is an acceptable alternative, I would very much like to try expanding the "Random generator and text with OpenCV" tutorial to include Python. Thank you!

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

@dmallia17 Functions like theRNG that returns default OpenCV random generator are not wrapped into Python bindings and you need to use alternatives. Numpy np.random is good choice. Some OpenCV algorithms are stochastic by design and use OpenCV RNG implementation internally. You still can manage their parameters in Python with calls like setRNGSeed.

@asmorkalov
Copy link
Copy Markdown
Contributor

@dmallia17 Could you squash the commits to have clean library history?

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label May 6, 2020
@dmallia17
Copy link
Copy Markdown
Contributor Author

@asmorkalov I believe that should do it - please correct me if I'm wrong. (First time having to squash commits for a PR!)

Also thank you very much for the explanation! I did spot setRNGSeed but wasn't sure of its usage. I am hopeful that I will be able to tackle expanding that tutorial very soon.

@asmorkalov asmorkalov self-requested a review May 7, 2020 08:29
@asmorkalov asmorkalov self-assigned this May 7, 2020
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@opencv-pushbot opencv-pushbot merged commit 73bbabc into opencv:3.4 May 7, 2020
@dmallia17
Copy link
Copy Markdown
Contributor Author

@asmorkalov Thank you! After looking around a bit further, I have found a couple of other tutorial modules where the table of contents should be updated. Would it be best to make a pull request for each table of contents or update all of the ones I spot at once?

@alalek
Copy link
Copy Markdown
Member

alalek commented May 7, 2020

@dmallia17 Thank you for contribution! Feel free to create single Pull Request with similar changes.

@dmallia17
Copy link
Copy Markdown
Contributor Author

@alalek Thank you very much - will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants