Merged
Conversation
Contributor
Author
|
Notice that in 3.4, 'tegra::calcSharrDeriv' is used if HAVE_TEGRA_OPTIMIZATION. This function is in Opencv4Tegra and I think it is a subsequent mistake following original OpenCV. I'm new to this community so I don't know if there is any way to fix that. |
dkurt
reviewed
Apr 29, 2020
dkurt
reviewed
Apr 29, 2020
| calcScharrDeriv(prevPyr[level * lvlStep1], derivI); | ||
| copyMakeBorder(derivI, _derivI, winSize.height, winSize.height, winSize.width, winSize.width, BORDER_CONSTANT|BORDER_ISOLATED); | ||
| } | ||
| else |
Member
There was a problem hiding this comment.
grep shows there there should be 6 entries:
$ grep -r "Sharr" ~/opencv
./modules/video/src/lkpyramid.cpp:static void calcSharrDeriv(const cv::Mat& src, cv::Mat& dst)
./modules/video/src/lkpyramid.cpp: parallel_for_(Range(0, rows), cv::detail::SharrDerivInvoker(src, dst), cv::getNumThreads());
./modules/video/src/lkpyramid.cpp:void cv::detail::SharrDerivInvoker::operator()(const Range& range) const
./modules/video/src/lkpyramid.cpp: if (tegra::useTegra() && tegra::calcSharrDeriv(src, dst))
./modules/video/src/lkpyramid.cpp: calcSharrDeriv(thisLevel, derivI);
./modules/video/src/lkpyramid.cpp: calcSharrDeriv(prevPyr[level * lvlStep1], derivI);
Member
There was a problem hiding this comment.
Oh, I see, you have already mentioned tegra::calcSharrDeriv
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge aim to fix a historical nominating mistake
Resolves issue #17175
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.