features2d: move SIFT to main repository#17119
Merged
opencv-pushbot merged 21 commits intoopencv:3.4from Apr 24, 2020
Merged
Conversation
- with big images the int multiplication can overflow original commit: opencv/opencv_contrib@d4df727
original commit: opencv/opencv_contrib@cb7b59f
original commit: opencv/opencv_contrib@c5e55df
…lify 2 lines of AVX2 instructions original commit: opencv/opencv_contrib@443f68c
…e keypoints afterwards to make the output stable original commit: opencv/opencv_contrib@6be2945
…act version original commit: opencv/opencv_contrib@8c394a4
…-dragon:conditionally_compute_dog_pyramid Build DoG Pyramid if useProvideKeypoints is false The buildDoGPyramid operation need not be performed unconditionally. In cases where it is not needed, both memory and speed performance can be improved original commit: opencv/opencv_contrib@e45887e
- should unlock IPP optimizations original commit: opencv/opencv_contrib@ce7c8f2
mshabunin
approved these changes
Apr 21, 2020
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
Maybe we could add a temporary typedef xfeatures2d::SIFT -> SIFT to smooth the transition, or is it in opencv_contrib already?
mshabunin
approved these changes
Apr 21, 2020
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
Maybe we could add a temporary typedef xfeatures2d::SIFT -> SIFT to smooth the transition, or is it in opencv_contrib already?
Member
Author
|
MSVS emits ambiguous errors for typedef, reverted. |
This was referenced Apr 24, 2020
Merged
This was referenced Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with contrib: opencv/opencv_contrib#2506
relates #16736
opencv_contrib's
sift.cpphistory.TODO:
cv::xfeatures2d::SIFT::create()(problem is due MSVS ambiguous errors)cv.xfeatures2d.SIFT_create()org.opencv.features2d.SIFT.create()