Skip to content

videoio: added plug-in support to MSMF backend#17009

Merged
opencv-pushbot merged 2 commits intoopencv:masterfrom
mshabunin:msmf-plugin
Apr 8, 2020
Merged

videoio: added plug-in support to MSMF backend#17009
opencv-pushbot merged 2 commits intoopencv:masterfrom
mshabunin:msmf-plugin

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Apr 7, 2020 •
edited by alalek
Loading

  • enabled by cmake option VIDEOIO_PLUGIN_LIST=msmf
  • OPENCV_VIDEOIO_PLUGIN_PATH environment variable should be set correctly

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom Win
build_image:Custom Win=msvs2019

allow_multiple_commits=1

alalek
alalek reviewed Apr 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alalek
Copy link
Copy Markdown
Member

alalek commented Apr 7, 2020

"Custom Win" builder with enabled MSMF plugin:

/OUT:"C:\build\precommit_custom_windows\build\lib\Release\opencv_videoio_msmf430_64.dll"

Need to change/add RUNTIME_OUTPUT_DIRECTORY target property:

-build\lib\Release\
+build\bin\Release\
  1. build warning:

modules\videoio\src\cap_msmf.cpp(1783,105): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

@alalek
Copy link
Copy Markdown
Member

alalek commented Apr 8, 2020

The first problem is still here:

/OUT:"C:\build\precommit_custom_windows\build\lib\Release\opencv_videoio_msmf430_64.dll"

alalek
alalek approved these changes Apr 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit acede97 into opencv:master Apr 8, 2020
@mshabunin mshabunin mentioned this pull request Apr 8, 2020
Closed
@mshabunin mshabunin deleted the msmf-plugin branch May 6, 2020 12:35
@opencv-alalek opencv-alalek mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: videoio feature platform: win32

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mshabunin @alalek @opencv-pushbot