Skip to content

Add text recognition to examples_dnn_text_decoder#16941

Merged
alalek merged 1 commit intoopencv:3.4from
apertovs:examples_dnn_text_decoder
May 6, 2020
Merged

Add text recognition to examples_dnn_text_decoder#16941
alalek merged 1 commit intoopencv:3.4from
apertovs:examples_dnn_text_decoder

Conversation

@apertovs
Copy link
Copy Markdown
Contributor

@apertovs apertovs commented Mar 31, 2020 •
edited by dkurt
Loading

Trained model taked from here: https://github.com/meijieru/crnn.pytorch

How to convert from pb to onnx
Using classes from here: https://github.com/meijieru/crnn.pytorch/blob/master/models/crnn.py

import torch
import models.crnn as crnn

model = CRNN(32, 1, 37, 256)
model.load_state_dict(torch.load('crnn.pth'))
dummy_input = torch.randn(1, 1, 32, 100)
torch.onnx.export(model, dummy_input, "crnn.onnx", verbose=True)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

berak
berak reviewed Apr 1, 2020
View reviewed changes
samples/dnn/text_detection.cpp Outdated
"{ help h | | Print help message. }"
"{ input i | | Path to input image or video file. Skip this argument to capture frames from a camera.}"
"{ model_decoder m | | Path to a binary .pb file contains trained detector network.}"
"{ model_recognition | | Path to a binary .pb file contains trained recognition network.}"
Copy link
Copy Markdown
Contributor

@berak berak Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helo, just curious, which model is used here ?

and if it is not (yet) in the model zoo, shouldn't there be a download link somewhere ?

This was linked to issues Apr 1, 2020
Error while loading pytorch model in opencv #16662
Closed
Feature Request: cv::dnn::readNetFromONNX does not support parsing LSTM layer #12533
Closed
dkurt
dkurt reviewed Apr 1, 2020
View reviewed changes
@apertovs
Copy link
Copy Markdown
Contributor Author

apertovs commented Apr 1, 2020 •
edited
Loading

Trained model taked from here: github.com/meijieru/crnn.pytorch

How to convert from pth to onnx
Using classes from here: github.com/meijieru/crnn.pytorch/blob/master/models/crnn.py

import torch

model = CRNN(32, 1, 37, 256)
model.load_state_dict(torch.load('./crnn.pth'))
dummy_input = torch.randn(1, 1, 32, 100)
torch.onnx.export(model, dummy_input, "crnn.onnx", verbose=True)

dkurt
dkurt reviewed Apr 1, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 1, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 1, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 1, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 1, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 1, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 1, 2020
View reviewed changes
@alalek alalek mentioned this pull request Apr 2, 2020
Merged
6 tasks
themechanicalcoder
themechanicalcoder reviewed Apr 2, 2020
View reviewed changes
themechanicalcoder
themechanicalcoder reviewed Apr 2, 2020
View reviewed changes
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 9, 2020

@rngtna @dkurt What is the patch status? Could you review and list remaining items?

dkurt
dkurt reviewed Apr 10, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 10, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 10, 2020
View reviewed changes
dkurt
dkurt reviewed Apr 18, 2020
View reviewed changes
alalek
alalek reviewed Apr 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

Please take a look on comments below.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 28, 2020

@rngtna Friendly reminder.

@apertovs apertovs force-pushed the examples_dnn_text_decoder branch from db23f51 to 5518973 Compare May 5, 2020 09:13
@dkurt dkurt changed the base branch from master to 3.4 May 5, 2020 09:13
dkurt
dkurt reviewed May 5, 2020
View reviewed changes
dkurt
dkurt reviewed May 5, 2020
View reviewed changes
dkurt
dkurt reviewed May 5, 2020
View reviewed changes
dkurt
dkurt reviewed May 5, 2020
View reviewed changes
dkurt
dkurt reviewed May 5, 2020
View reviewed changes
dkurt
dkurt reviewed May 5, 2020
View reviewed changes
@dkurt
Copy link
Copy Markdown
Member

dkurt commented May 6, 2020

@rngtna, please resolve compilation warnings: https://pullrequest.opencv.org/buildbot/builders/precommit_windows64/builds/24606

@apertovs apertovs force-pushed the examples_dnn_text_decoder branch from 663b547 to 00b19d6 Compare May 6, 2020 12:27
dkurt
dkurt approved these changes May 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done!

@dkurt dkurt self-assigned this May 6, 2020
@alalek alalek merged commit 4f1ba5e into opencv:3.4 May 6, 2020
@alalek alalek mentioned this pull request May 6, 2020
Merged
@amandazw amandazw mentioned this pull request Sep 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

@alalek alalek Awaiting requested review from alalek

+2 more reviewers

@berak berak berak left review comments

@themechanicalcoder themechanicalcoder themechanicalcoder left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dkurt dkurt

Labels

category: dnn category: samples feature

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

Error while loading pytorch model in opencv Feature Request: cv::dnn::readNetFromONNX does not support parsing LSTM layer

6 participants

@apertovs @asmorkalov @dkurt @berak @alalek @themechanicalcoder