Skip to content

Case sensitive dnn layers types#16878

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:fix_16877
Apr 6, 2020
Merged

Case sensitive dnn layers types#16878
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:fix_16877

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Mar 22, 2020 •
edited by alalek
Loading

resolves #16877

  • Remove toLoweCase for types when construct dnn layers
  • Register SoftMax for compatibility (there are number of tests which showed "SoftMax" type name). Origin type is Softmax

I'd like to recommend to merge after the release.

/cc @YashasSamaga

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.1.0:16.04
build_image:Custom Win=openvino-2020.1.0
build_image:Custom Mac=openvino-2020.1.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@dkurt dkurt added this to the 3.4.11 milestone Mar 22, 2020
@dkurt dkurt mentioned this pull request Mar 22, 2020
Closed
4 tasks
@dkurt dkurt linked an issue Mar 25, 2020 that may be closed by this pull request
dnn: missed fusion opportunities by using case-sensitive string comparisions to identify layer types #16877
Closed
4 tasks
@dkurt dkurt requested a review from l-bat April 4, 2020 11:03
l-bat
l-bat reviewed Apr 4, 2020
View reviewed changes
@l-bat
Copy link
Copy Markdown
Contributor

l-bat commented Apr 4, 2020

Thank you 👍!

@opencv-pushbot opencv-pushbot merged commit ce5626d into opencv:3.4 Apr 6, 2020
@alalek alalek mentioned this pull request Apr 7, 2020
Merged
@dkurt dkurt mentioned this pull request Apr 8, 2020
Merged
@berak berak mentioned this pull request Jun 3, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l-bat l-bat l-bat approved these changes

Assignees

@l-bat l-bat

Labels

bug category: dnn

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

dnn: missed fusion opportunities by using case-sensitive string comparisions to identify layer types

3 participants

@dkurt @l-bat @opencv-pushbot