[WIP] Ceil, Floor, Log, Round, Sqrt layers added#16750
[WIP] Ceil, Floor, Log, Round, Sqrt layers added#16750ashishkrshrivastava wants to merge 2 commits intoopencv:3.4from
Conversation
d6fe8f5 to
4c83084
Compare
|
Failed builders have GCC 4.x. |
1a63847 to
2720dc2
Compare
|
@alalek thanks. |
|
@alalek , is there any documentation where I can get to know about the configuration of builders like what version of gcc or C++ custom builder use ? |
Check "CMake" step => "stdio" log.
These builders are configured to build OpenCV with OpenVINO's Inference engine (Open Source version is here: https://github.com/opencv/dldt/releases/tag/2020.1). General information about IE and how to build OpenCV with IE locally: https://github.com/opencv/opencv/wiki/Intel%27s-Deep-Learning-Inference-Engine-backend#build-opencv-from-source
You should tune implementation details through General information about CI options: https://github.com/opencv/opencv/wiki/CI-configuration |
2720dc2 to
e1ecb87
Compare
|
@alalek Thank you so much. |
|
Please see the comment #16749 (comment). I think that adding so atomic operations is not a right way to enable object detection networks. They won't cover all the operations from the models and we need more fundamental solution. Can you specify origin frameworks for YOLOv3 and Faster R-CNN models in ONNX format? |
|
@dkurt , all of object detection models are originated from keras2onnx. They are written in keras. |
It can be useful, for example, for debugging purposes of graph transformations. |
I have added explanation in #16749 comment . Please share your view. |
e1ecb87 to
7797167
Compare
|
@alalek , necessary lines of code is already added to PR description to allow custom build then why it is not getting build. Am I missing something ? |
7797167 to
9059681
Compare
|
@alalek , sorry opencv/opencv_extra#723 had merge conflict yesteday, I have resolved them. can you please let build on custom builders. |
|
I re-triggered all builds, include custom one. |
Thank you so much @asmorkalov . They all are build successfully. |
Please specify if this PR enables one of the models mentioned in the issue |
|
@dkurt Actually I created the issue requesting layer implementation, not model. But as you said that we must focus on models not operators or layers, making models work needs several fusion and layer implementation. It would take time. So if you want me to make model work, please let the PR open. I will complete that. Otherwise this PR can be merged for now since layer implementation is already there and I will work on models separately. |
0fd11b8 to
e946267
Compare
|
@alalek , I am adding a layer which needs changes in Am i missing something ? I am sorry to ask this question here. |
out of source tree. |
ohh.. need to add changes here |
aa00911 to
bf68c96
Compare
bf68c96 to
e0bd5d5
Compare
|
I think these changes are not relevant anymore. Closing it for now. I would definitely work on it if find any issue regarding this in future. |
resolves #16749
Merge with extra: opencv/opencv_extra#723
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
This PR adds implementation of
Ceil LayerFloor LayerRound LayerLog LayerSqrt LayerExp LayerNot LayerReduceMin(only for constant because it is working on constants in fasterrcnn and maskrcnn )NonZero(only for constant blob because it is working on constants in fasterrcnn and maskrcnn)EqualGreaterLessAndGatherTopK