Skip to content

(3.4) DNN(IE): use HAVE_DNN_IE_NN_BUILDER_2019 for NN Builder API code#16719

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:dnn_disable_nn_builder_api_3.4
Mar 6, 2020
Merged

(3.4) DNN(IE): use HAVE_DNN_IE_NN_BUILDER_2019 for NN Builder API code#16719
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:dnn_disable_nn_builder_api_3.4

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Mar 3, 2020 •
edited
Loading

backport #16694

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.1.0:16.04
build_image:Custom Win=openvino-2020.1.0
build_image:Custom Mac=openvino-2020.1.0

Xtest_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@alalek
dnn(IE): use HAVE_DNN_IE_NN_BUILDER_2019 for NN Builder API code
124bf83 
- CMake option: OPENCV_DNN_IE_NN_BUILDER_2019
dkurt
dkurt reviewed Mar 5, 2020
View reviewed changes
modules/dnn/CMakeLists.txt

set(dnn_runtime_libs "")
if(INF_ENGINE_TARGET)
ocv_option(OPENCV_DNN_IE_NN_BUILDER_2019 "Build with Inference Engine NN Builder API support" ON)
Copy link
Copy Markdown
Member

@dkurt dkurt Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not OFF by default?

Copy link
Copy Markdown
Member Author

@alalek alalek Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current patch state helps to ensure that we don't lost anything (accuracy / performance).

I will switch defaults in another small commit including backend value for IE.

dkurt
dkurt approved these changes Mar 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@dkurt dkurt self-assigned this Mar 5, 2020
@alalek
Copy link
Copy Markdown
Member Author

alalek commented Mar 5, 2020

Need to resolve issues on the "master" branch before merge: #16694

@opencv-pushbot opencv-pushbot merged commit 094a5b0 into opencv:3.4 Mar 6, 2020
@alalek alalek mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Milestone

3.4.10

Development

Successfully merging this pull request may close these issues.

3 participants

@alalek @dkurt @opencv-pushbot