Ignore clang warnings for deprecated enum+enum operations in mat.inl.hpp#16684
Merged
alalek merged 2 commits intoopencv:3.4from Feb 28, 2020
pwuertz:ignore_clang_mat_inl
Merged
Ignore clang warnings for deprecated enum+enum operations in mat.inl.hpp#16684alalek merged 2 commits intoopencv:3.4from pwuertz:ignore_clang_mat_inl
alalek merged 2 commits intoopencv:3.4from
pwuertz:ignore_clang_mat_inl
Conversation
Contributor
Author
|
Shall I squash your changes into one commit? |
Member
|
Not necessary, I can squash them during merge. |
alalek
approved these changes
Feb 28, 2020
Member
alalek
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for contribution 👍
Merged
4 tasks
|
These are now hard errors with clang 18 :( |
|
Yup, it's hard errors now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent versions of
clangemit warnings for deprecatedenum+other_enumexpressions (Compiler Explorer Example).mat.inl.hpprelies quite extensively on those expressions for joining flags, which shows when using OpenCV with the latest Emscripten release for example.As a least-intrusive option, I added a local
clang diagnostic ignoredpragma for this warning type.