Skip to content

add Copy to clipboard functional to imshow wnd with Qt#16677

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
Bleach665:Qt_imshow_clipbrd
Feb 28, 2020
Merged

add Copy to clipboard functional to imshow wnd with Qt#16677
opencv-pushbot merged 1 commit intoopencv:3.4from
Bleach665:Qt_imshow_clipbrd

Conversation

@Bleach665
Copy link
Copy Markdown
Contributor

@Bleach665 Bleach665 commented Feb 27, 2020

Adds "copy to clipboard" button to imshow window if opencv was built with Qt.
Tested on Windows 10, MACOS 10.14.6, Xubuntu 18.04.2, Qt 5.11.xx.

force_builders=Custom
build_image:Custom=qt:16.04
buildworker:Custom=linux-1,linux-2,linux-4

@asmorkalov
Copy link
Copy Markdown
Contributor

@Bleach665 interesting function, thanks! Could you add notes to the project documentation to promote the feature. Users do not know about that and cannot get it without documentation.

@asmorkalov asmorkalov added the pr: needs docs Please update corresponding documentation label Feb 27, 2020
@Bleach665
Copy link
Copy Markdown
Contributor Author

@asmorkalov,

Could you add notes to the project documentation

Of course, but please lead me to example what the documentation should look like.
In our case it's just another button on the panel.
001

By clicking on it, we copy the image to the clipboard. Also "Ctrl+C" keyboard shortcut can be used.

@asmorkalov
Copy link
Copy Markdown
Contributor

You can extend this page that is generated for this header file preambule. In addition you can extend cv::imshow documentation and add note about backend specific functionality like it's done for cv::imread.
Also, please take a look on CI status, CI Bot reports trailing white spaces issue: https://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/24017/steps/whitespace%20opencv/logs/stdio

@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 27, 2020

Thank you for contribution!

There is no documentation for any of other Qt U/I buttons. So my suggestion is to avoid adding them (perhaps separate page/tutorial would be better).

Please fix "Docs" whitespace warnings and rebase onto 3.4 branch.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@Bleach665 Bleach665 changed the base branch from master to 3.4 February 27, 2020 20:52
@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 27, 2020

Repair branch:

$ git checkout -B Qt_imshow_clipbrd 9db999eac29f42e8c3b1356b09b884174b1f7ed5

and try again.

@Bleach665
Copy link
Copy Markdown
Contributor Author

Ok. thanks

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 1bc607e into opencv:3.4 Feb 28, 2020
@alalek alalek mentioned this pull request Feb 28, 2020
@Bleach665 Bleach665 deleted the Qt_imshow_clipbrd branch February 28, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants