Skip to content

Darknet_io: Parsing for cost layer added#16650

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
ashishkrshrivastava:cvdarknet
Feb 25, 2020
Merged

Darknet_io: Parsing for cost layer added#16650
opencv-pushbot merged 1 commit intoopencv:3.4from
ashishkrshrivastava:cvdarknet

Conversation

@ashishkrshrivastava
Copy link
Copy Markdown
Contributor

@ashishkrshrivastava ashishkrshrivastava commented Feb 23, 2020

Merge with extra: opencv/opencv_extra#714
resolves #16623

opencv_extra=cvdarknet

Pull Request Readiness Checklist

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

This PR adds

Parsing for [cost] layer in darknet_io. Modifications are made to treat [cost] layer as identity layer.

@ashishkrshrivastava ashishkrshrivastava mentioned this pull request Feb 23, 2020
Merged
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Feb 23, 2020

@ashishkrshrivastava, Please add this layer to one of the existing .cfg files from tests so we can cover it.

@ashishkrshrivastava
Copy link
Copy Markdown
Contributor Author

ashishkrshrivastava commented Feb 23, 2020

@dkurt , I have added [cost] in connected.cfg as you suggested.

dkurt
dkurt approved these changes Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done!

@dkurt dkurt self-assigned this Feb 24, 2020
@opencv-pushbot opencv-pushbot merged commit a5d0c7b into opencv:3.4 Feb 25, 2020
@alalek alalek mentioned this pull request Feb 26, 2020
Merged
@ashishkrshrivastava ashishkrshrivastava deleted the cvdarknet branch March 4, 2020 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn

Projects

None yet

Milestone

3.4.10

Development

Successfully merging this pull request may close these issues.

4 participants

@ashishkrshrivastava @dkurt @opencv-pushbot @alalek