Skip to content

dnn: fix processing of input shapes#16616

Merged
alalek merged 2 commits intoopencv:3.4from
alalek:dnn_fix_input_shape
Feb 21, 2020
Merged

dnn: fix processing of input shapes#16616
alalek merged 2 commits intoopencv:3.4from
alalek:dnn_fix_input_shape

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Feb 18, 2020 •
edited
Loading

resolves #16618

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.1.0:16.04
build_image:Custom Win=openvino-2020.1.0
build_image:Custom Mac=openvino-2020.1.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@alalek alalek mentioned this pull request Feb 19, 2020
Merged
@dkurt dkurt self-assigned this Feb 19, 2020
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Feb 20, 2020

@alalek, I think that it's better to experiment with this feature on master branch. Because it's actually used there and we decided to backport to 3.4 branch just to make it easier for merging.

dkurt
dkurt reviewed Feb 21, 2020
View reviewed changes
@alalek
dnn: fix processing of input shapes
35696ab 
- importer: avoid using of .setInput() => .setInputShape()
- setInput: shape limitation check (partial)
dkurt
dkurt approved these changes Feb 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

dkurt
dkurt reviewed Feb 21, 2020
View reviewed changes
@alalek alalek merged commit 01048e5 into opencv:3.4 Feb 21, 2020
@alalek alalek mentioned this pull request Feb 26, 2020
Merged
@dkurt dkurt mentioned this pull request Sep 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

bug category: dnn test

Projects

None yet

Milestone

3.4.10

Development

Successfully merging this pull request may close these issues.

2 participants

@alalek @dkurt