Skip to content

Minor update in grabcut.py#16610

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
muhammadtahasuhail:patch-1
Feb 20, 2020
Merged

Minor update in grabcut.py#16610
opencv-pushbot merged 1 commit intoopencv:3.4from
muhammadtahasuhail:patch-1

Conversation

@muhammadtahasuhail
Copy link
Copy Markdown
Contributor

@muhammadtahasuhail muhammadtahasuhail commented Feb 18, 2020

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [ x] I agree to contribute to the project under OpenCV (BSD) License.
  • [ x] To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • [ x] The PR is proposed to proper branch
  • [ x] There is reference to original bug report and related work
  • [ x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [ x] The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 18, 2020

Thank you for contribution!

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@muhammadtahasuhail muhammadtahasuhail changed the base branch from master to 3.4 February 18, 2020 17:57
@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 19, 2020

1,142 commits

You need to complete rebase and force push new commit into your fork.
As a result you should see "1 commit" in this PR.

@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Feb 20, 2020
@asmorkalov asmorkalov self-requested a review February 20, 2020 13:23
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 20, 2020

@alalek I rebased the branch. Could you look at it and merge. 👍

@opencv-pushbot opencv-pushbot merged commit 150c293 into opencv:3.4 Feb 20, 2020
@alalek alalek mentioned this pull request Feb 20, 2020
Merged
@muhammadtahasuhail muhammadtahasuhail deleted the patch-1 branch February 22, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: samples

Projects

None yet

Milestone

3.4.10

Development

Successfully merging this pull request may close these issues.

4 participants

@muhammadtahasuhail @alalek @asmorkalov @opencv-pushbot