fixed issue with Mat reshape in decodeMulti()#16491
Merged
alalek merged 3 commits intoopencv:3.4from Feb 4, 2020
Merged
Conversation
Contributor
|
@rayonnant14 Could you add a test for the resolved bug? |
Member
|
Add simple "bad" test (~10 lines): |
alalek
reviewed
Feb 4, 2020
Member
alalek
left a comment
There was a problem hiding this comment.
Well done! Test looks good to me
| #ifdef HAVE_QUIRC | ||
| Mat zero_image = Mat::zeros(256, 256, CV_8UC1); | ||
| std::vector<Point> vec_corners{Point(16, 16), Point(128, 16), Point(128, 128), Point(16, 128), | ||
| Point(16, 16), Point(128, 16), Point(128, 128), Point(16, 128)}; |
Member
There was a problem hiding this comment.
C++11 is not allowed in OpenCV tests on 3.4 branch by default.
Please use Points corners_[] = {...}; array + vector::assign()
alalek
approved these changes
Feb 4, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solved problem with incorrect processing of transformation points in method QRCodeDetector::decodeMulti()
relates #15338