Skip to content

TF importer: Corrected end tensor_content parsing for StridedSlice layer.#16473

Merged
alalek merged 1 commit intoopencv:3.4from
ashishkrshrivastava:opencvtf
Feb 9, 2020
Merged

TF importer: Corrected end tensor_content parsing for StridedSlice layer.#16473
alalek merged 1 commit intoopencv:3.4from
ashishkrshrivastava:opencvtf

Conversation

@ashishkrshrivastava
Copy link
Copy Markdown
Contributor

@ashishkrshrivastava ashishkrshrivastava commented Jan 31, 2020 •
edited by dkurt
Loading

Merge with extra: opencv/opencv_extra#704
resolves #16337

This pullrequest changes

Setting of end Mat values using tensor_content of "cropping2d/strided_slice/stack_1" from pbtxt file.

opencv_extra=opencv_extratf

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r3.0:16.04
build_image:Custom Win=openvino-2019r3.0
build_image:Custom Mac=openvino-2019r3.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

dkurt
dkurt reviewed Feb 2, 2020
View reviewed changes
@dkurt dkurt added the pr: needs test New functionality requires minimal tests set label Feb 3, 2020
@ashishkrshrivastava ashishkrshrivastava mentioned this pull request Feb 5, 2020
Merged
@dkurt dkurt removed the pr: needs test New functionality requires minimal tests set label Feb 6, 2020
dkurt
dkurt reviewed Feb 7, 2020
View reviewed changes
@dkurt dkurt self-assigned this Feb 7, 2020
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Feb 8, 2020

Please increase test tolerance for Myriad device:

[ RUN      ] Test_TensorFlow_layers.slice/1, where GetParam() = DLIE/MYRIAD
/build/precommit_custom_linux/3.4/opencv/modules/dnn/test/test_common.impl.hpp:66: Failure
Expected: (normL1) <= (l1), actual: 0.00482579 vs 0.004
[  FAILED  ] Test_TensorFlow_layers.slice/1, where GetParam() = DLIE/MYRIAD (76 ms)

https://pullrequest.opencv.org/buildbot/builders/precommit_custom_linux/builds/3311

dkurt
dkurt approved these changes Feb 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done! Thanks for your contribution!

@dkurt dkurt linked an issue Feb 9, 2020 that may be closed by this pull request
TF importer: StridedSlice gives different shape compared to TF #16337
Closed
@alalek alalek merged commit db9f443 into opencv:3.4 Feb 9, 2020
@ashishkrshrivastava
Copy link
Copy Markdown
Contributor Author

ashishkrshrivastava commented Feb 9, 2020

Well done! Thanks for your contribution!

Thanks.

@alalek alalek mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

bug category: dnn

Projects

None yet

Milestone

3.4.10

Development

Successfully merging this pull request may close these issues.

TF importer: StridedSlice gives different shape compared to TF

3 participants

@ashishkrshrivastava @dkurt @alalek