Skip to content

Added type check for solvePnPGeneric | Issue: #16049#16405

Merged
alalek merged 4 commits intoopencv:3.4from
ganesh-k13:bugfix/solvepnp-crash
Jan 23, 2020
Merged

Added type check for solvePnPGeneric | Issue: #16049#16405
alalek merged 4 commits intoopencv:3.4from
ganesh-k13:bugfix/solvepnp-crash

Conversation

@ganesh-k13
Copy link
Copy Markdown
Contributor

@ganesh-k13 ganesh-k13 commented Jan 22, 2020

This pullrequest changes

Added default type instead of reprojectionError.type()

Refers #16049

@ganesh-k13
Copy link
Copy Markdown
Contributor Author

ganesh-k13 commented Jan 22, 2020

Hi @alalek, I am unsure how to add tests, I raised a question here: https://answers.opencv.org/question/225157/how-to-trigger-tests-in-miscpythontest/

@ganesh-k13 ganesh-k13 changed the title Added type check Added type check for solvePnPGeneric | Issue: #16049 Jan 22, 2020
@alalek
Copy link
Copy Markdown
Member

alalek commented Jan 22, 2020

  • without run.py:
PYTHONPATH=${OPENCV_SRC_DIR}/modules/python/test ./setup_vars.sh python ${OPENCV_SRC_DIR}/modules/calib3d/misc/python/test/test_solvepnp.py
  • with run.py:
OPENCV_PYTEST_FILTER=test_solvepnp ./setup_vars.sh python ${OPENCV_SRC_DIR}/modules/ts/misc/run.py -a -t python3

alalek
alalek reviewed Jan 22, 2020
View reviewed changes
@ganesh-k13
Copy link
Copy Markdown
Contributor Author

ganesh-k13 commented Jan 23, 2020

I'll add tests shortly.

@asmorkalov asmorkalov added the pr: needs test New functionality requires minimal tests set label Jan 23, 2020
@ganesh-k13 ganesh-k13 requested a review from alalek January 23, 2020 08:16
alalek
alalek approved these changes Jan 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@alalek alalek merged commit 504cd8a into opencv:3.4 Jan 23, 2020
@ganesh-k13
Copy link
Copy Markdown
Contributor Author

ganesh-k13 commented Jan 23, 2020

Hi @alalek, thanks for the help. This test won't be triggered by the CI right, do we add a UT for this?

@alalek
Copy link
Copy Markdown
Member

alalek commented Jan 23, 2020

Test is triggered in "python2" / "python3" steps. See here.

@ganesh-k13
Copy link
Copy Markdown
Contributor Author

ganesh-k13 commented Jan 23, 2020

Oh ok thanks.

@alalek alalek mentioned this pull request Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: calib3d category: python bindings test

Projects

None yet

Milestone

3.4.10

Development

Successfully merging this pull request may close these issues.

3 participants

@ganesh-k13 @alalek @asmorkalov