Skip to content

cmake: support OPENCV_ABI_SKIP_MODULES_LIST#16338

Merged
alalek merged 1 commit intoopencv:masterfrom
alalek:abi_checker_exclude_modules
Jan 28, 2020
Merged

cmake: support OPENCV_ABI_SKIP_MODULES_LIST#16338
alalek merged 1 commit intoopencv:masterfrom
alalek:abi_checker_exclude_modules

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Jan 13, 2020

To regenerate ABI/API snapshot of OpenCV 4.2.0 without G-API module

relates #16118

@dmatveev
Copy link
Copy Markdown
Contributor

As the opposite, is there any way to mark problematic (for ABI checker) parts of code to skip the check, but to keep it for the rest of G-API?

@dmatveev
Copy link
Copy Markdown
Contributor

--- _ZN2cv6detail10MetaHelperINS_4gapi4core8GAbsDiffESt5tupleIJNS_4GMatES6_EES6_E10getOutMetaERKSt6vectorINS_4util7variantIJNSA_9monostateENS_8GMatDescENS_11GScalarDescENS_10GArrayDescEEEESaISG_EERKS9_INS_4GArgESaISL_EE
+++ _ZN2cv6detail10MetaHelperINS_4gapi4core8GAbsDiffESt5tupleIJNS_4GMatES6_EES6_E10getOutMetaERKSt6vectorINS_4util7variantIJNSA_9monostateENS_8GMatDescENS_11GScalarDescENS_10GArrayDescENS_11GOpaqueDescEEEESaISH_EERKS9_INS_4GArgESaISM_EE

This and other ~180 hits are purely mangling stuff, but source-level compatibility is preserved

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Jan 13, 2020

Used tool "abi-compliance-checker" is not very good on source-level compatibility checks. It is designed as ABI checker at first. API (source) check list is just relaxed subset of ABI checks.

There are too many false positive hits on GAPI (and non G-API) patches.
Lets try to "validate" source-level compatibility through compilation of corresponding tests and samples. G-API has good coverage (than other OpenCV code), so serious issues should not pass.

@dmatveev
Copy link
Copy Markdown
Contributor

I think this particular ABI false alarm can be fixed, though the fix will generate 180 hits again :)

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Jan 27, 2020

👍

@alalek alalek merged commit f856c96 into opencv:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants