Changed plus operator to os.path.join()#16240
Merged
alalek merged 2 commits intoopencv:3.4from Jan 10, 2020
Merged
Conversation
alalek
reviewed
Dec 26, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
Please try to run tests locally (see build CI step logs).
| class qrcode_detector_test(NewOpenCVTests): | ||
| def test_detect_and_decode(self): | ||
| img = cv.imread(self.extraTestDataPath + '/cv/qrcode/link_ocv.jpg') | ||
| img = cv.imread(os.path.join(self.extraTestDataPath, '/cv/qrcode/link_ocv.jpg')) |
Member
There was a problem hiding this comment.
I would suggest removing slash too (there is no absolute path):
'/cv/
'cv/Also it would be nice to check that input data is read properly (img != None)
Member
|
This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
Contributor
Author
|
@alalek |
Member
|
I provided detailed instructions above.
There is no "merge" step. I can take a look on this later. |
alalek
approved these changes
Jan 10, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dealing with PATH, it is not recommended to use the plus operator (+). So, I used os.path.join().