Merged
Conversation
terfendail
reviewed
Jan 9, 2020
terfendail
reviewed
Jan 9, 2020
| static inline Tvec r(const Tvec& a, const Tvec& b) | ||
| { | ||
| const Tvec v_zero = Tvec(); | ||
| const Tvec v_zero = vx_setall<typename Tvec::lane_type>(0); |
Contributor
There was a problem hiding this comment.
IMO it make sense to add vx_setzero template as well and use it here instead
Member
Author
There was a problem hiding this comment.
Will be added as a separate PR
terfendail
reviewed
Jan 10, 2020
| yf0 = v_fma(v_cvt_f32(yi0), vln2, yf0); | ||
|
|
||
| v_float32 delta = v_reinterpret_as_f32(h0 == vx_setall_s32(510)) & vshift; | ||
| v_float32 delta = v_select(v_reinterpret_as_f32(h0 == vx_setall_s32(510)), vshift, vx_setall<float>(0)); |
Contributor
There was a problem hiding this comment.
There is a possibility that this version will be slower on SSE2 and SSE3. However I think the line could be optimized by a compiler.
terfendail
approved these changes
Jan 10, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with contrib: opencv/opencv_contrib#2403
Usage: