Skip to content

Eltwise::DIV support in Halide backend#16156

Merged
alalek merged 6 commits intoopencv:3.4from
TH3CHARLie:3.4
Dec 13, 2019
Merged

Eltwise::DIV support in Halide backend#16156
alalek merged 6 commits intoopencv:3.4from
TH3CHARLie:3.4

Conversation

@TH3CHARLie
Copy link
Copy Markdown
Contributor

@TH3CHARLie TH3CHARLie commented Dec 13, 2019 •
edited by alalek
Loading

resolves #15893

This pullrequest changes

This PR adds Halide support for DNN::Eltwise::DIV

force_builders=Custom,docs
buildworker:Custom=linux-4
docker_image:Custom=halide:16.04
test_filter:Custom=*Halide*

build_image:Custom Mac=openvino-2019r3.0
build_image:Custom Win=openvino-2019r3.0
test_opencl:Custom Win=OFF
#build_image:Custom Win=msvs2017
#build_image:Custom Win=msvs2019
test_modules:Custom Mac=dnn,java,python3

@TH3CHARLie TH3CHARLie closed this Dec 13, 2019
@TH3CHARLie TH3CHARLie reopened this Dec 13, 2019
@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 13, 2019

Generated test input is not good for "DIV" test.
Please update test input generation:

  • divisor values should not be near or equal to zero
  • lets ensure fabs(divisor) > 0.5 (fix values)

@TH3CHARLie
Copy link
Copy Markdown
Contributor Author

TH3CHARLie commented Dec 13, 2019

Generated test input is not good for "DIV" test.
Please update test input generation:

  • divisor values should not be near or equal to zero
  • lets ensure fabs(divisor) > 0.5 (fix values)

I use a pretty ad-hoc approach now, if the op is div, use randu to ensure filling the Mat using random value from 0.55f to 1.5f

alalek
alalek approved these changes Dec 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@alalek alalek merged commit 3d60a9b into opencv:3.4 Dec 13, 2019
@TH3CHARLie
Copy link
Copy Markdown
Contributor Author

TH3CHARLie commented Dec 13, 2019

Thanks for the review!

@alalek alalek mentioned this pull request Dec 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: dnn feature

Projects

None yet

Milestone

3.4.9

Development

Successfully merging this pull request may close these issues.

2 participants

@TH3CHARLie @alalek