Reading IR models from buffer#16015
Reading IR models from buffer#16015Quantizs wants to merge 0 commit intoopencv:masterfrom Quantizs:master
Conversation
|
@Quantizs, hi! Please change a base branch to 3.4 and choose a different name for feature branch: |
modules/dnn/src/dnn.cpp
Outdated
|
|
||
| cvNet.impl->skipInfEngineInit = true; | ||
| return cvNet; | ||
| } |
There was a problem hiding this comment.
Please create a separate method which returns cv::Net from reader. Let's reduce code duplication.
|
@dkurt hi, We are working on the requested changes, but as the merged branch cannot be changed (just the base) should we open a new PR? (We kind of missed the branch naming guidelines during our first read trough.) |
|
@marcellBan, it's more about general recommendation, not OpenCV only. If you add a commit to a local |
|
@dkurt, I totally understand and agree with it as I've worked with git for a few years now but I was asking if we should open a new PR with a different branch or should we just use this one and solve any upcoming git issues on our end. |
|
@marcellBan, If it's OK to modify the branch named
|
|
We rebased the forked branch on 3.4 and I have refactored the code as requested and pushed it to |
|
@Quantizs, can you please try to open a new one? |
resolves #15578
This pullrequest changes
Added implementations to load IR models from buffer