Skip to content

Reading IR models from buffer#16015

Closed
Quantizs wants to merge 0 commit intoopencv:masterfrom
Quantizs:master
Closed

Reading IR models from buffer#16015
Quantizs wants to merge 0 commit intoopencv:masterfrom
Quantizs:master

Conversation

@Quantizs
Copy link
Copy Markdown
Contributor

resolves #15578

This pullrequest changes

Added implementations to load IR models from buffer

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Nov 28, 2019

@Quantizs, hi!

Please change a base branch to 3.4 and choose a different name for feature branch:

git checkout 3.4
git checkout -b branch_name


cvNet.impl->skipInfEngineInit = true;
return cvNet;
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate method which returns cv::Net from reader. Let's reduce code duplication.

@dkurt dkurt mentioned this pull request Nov 28, 2019
@Quantizs Quantizs changed the base branch from master to 3.4 November 29, 2019 08:56
@Quantizs Quantizs changed the base branch from 3.4 to master November 29, 2019 08:58
@Quantizs Quantizs closed this Nov 29, 2019
@marcellBan
Copy link
Copy Markdown

@dkurt hi,

We are working on the requested changes, but as the merged branch cannot be changed (just the base) should we open a new PR? (We kind of missed the branch naming guidelines during our first read trough.)

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Nov 29, 2019

@marcellBan, it's more about general recommendation, not OpenCV only. If you add a commit to a local master branch, then you just cannot keep this branch aligned with a remote one. So it's better to create a separate branches for local changes but keep origin branches unchanged for robust pull procedures.

@marcellBan
Copy link
Copy Markdown

@dkurt, I totally understand and agree with it as I've worked with git for a few years now but I was asking if we should open a new PR with a different branch or should we just use this one and solve any upcoming git issues on our end.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Nov 29, 2019

@marcellBan, If it's OK to modify the branch named master locally, please try this:

  1. rename master to something temporal like fix
  2. go to branch 3.4
  3. git checkout -b master
  4. git cherry-pick your_commit_hash or just copy-paste the code and create a new commit
  5. push resulting branch with -f to the fork
  6. reopen this PR. Click Edit button where you can change target branch to 3.4

@Quantizs
Copy link
Copy Markdown
Contributor Author

We rebased the forked branch on 3.4 and I have refactored the code as requested and pushed it to Quantizs:master but i can't reopen the pull request or edit it.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Nov 30, 2019

@Quantizs, can you please try to open a new one?

@Quantizs
Copy link
Copy Markdown
Contributor Author

Quantizs commented Dec 2, 2019

@dkurt Reopen under #16034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read ir model from buffer not implemented

3 participants