Skip to content

Clarify stereoRectify() doc#15820

Merged
alalek merged 1 commit intoopencv:3.4from
oleg-alexandrov:patch-1
Nov 1, 2019
Merged

Clarify stereoRectify() doc#15820
alalek merged 1 commit intoopencv:3.4from
oleg-alexandrov:patch-1

Conversation

@oleg-alexandrov
Copy link
Copy Markdown
Contributor

The function stereoRectify() takes as input a coordinate transform between two cameras. It is ambiguous how it goes. I clarified that it goes from the second camera to the first.

This pullrequest changes

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 31, 2019

Please enable pre-commit hook to avoid whitespace issues: https://github.com/opencv/opencv/wiki/How_to_contribute#q3-i-was-asked-to-remove-whitespace-issues-how-can-i-do-that


This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@oleg-alexandrov oleg-alexandrov changed the base branch from master to 3.4 October 31, 2019 20:06
The function stereoRectify() takes as input a coordinate transform between two cameras. It is ambiguous how it goes. I clarified that it goes from the second camera to the first.
@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 1, 2019

I pushed rebased commits

@oleg-alexandrov
Copy link
Copy Markdown
Contributor Author

Thank you. I tried to rebase but got a conflict. I guess something like git cherry-pick would have worked.

@alalek alalek merged commit d56535a into opencv:3.4 Nov 1, 2019
@alalek alalek mentioned this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants