Supported ONNX Squeeze, ReduceL2 and Eltwise::DIV#15811
Merged
alalek merged 6 commits intoopencv:3.4from Nov 9, 2019
Merged
Conversation
dkurt
reviewed
Oct 30, 2019
dkurt
reviewed
Oct 31, 2019
| else if (layer_type == "ReduceL2") | ||
| { | ||
| CV_Assert(node_proto.input_size() == 1); | ||
| CV_Assert(graph_proto.node(li + 1).op_type() == "Div"); |
Member
There was a problem hiding this comment.
Please check that node_size more than li first:
CV_Assert(graph_proto.node_size() > li && graph_proto.node(li + 1).op_type() == "Div");
| ++li; | ||
|
|
||
| layerParams.type = "Normalize"; | ||
| layerParams.set("p", 2); |
| for (int j = 1; j < axes.size(); ++j) { | ||
| CV_Assert(axes[j - 1] + 1 == axes[j]); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Can we avoid using this code? I mean keep default values of Normalize layer
dkurt
reviewed
Nov 7, 2019
| if (constBlobs.find(node_proto.input(1)) == constBlobs.end()) { | ||
| layerParams.type = "Eltwise"; | ||
| layerParams.set("operation", "div"); | ||
| } else { |
Member
There was a problem hiding this comment.
Please format it in this way:
if
{
}
else
{
}
This was referenced Nov 11, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #15251
Merge with extra: opencv/opencv_extra#683