Use argument value for 'mat' in call to format for vector_mat and vector_mat_template#15765
Merged
alalek merged 2 commits intoopencv:3.4from Mar 4, 2020
Merged
Use argument value for 'mat' in call to format for vector_mat and vector_mat_template#15765alalek merged 2 commits intoopencv:3.4from
alalek merged 2 commits intoopencv:3.4from
Conversation
Member
|
Thank you for contribution! Please add some simple test here: https://github.com/opencv/opencv/blob/4.1.2/modules/python/test/test_umat.py |
Contributor
|
@zachlowry Friendly reminder. Do you have a chance to add test for your fix? |
Contributor
|
@VadimLevin could you join the discussion and propose test for the case? |
Contributor
|
@alalek I added tests, so PR is ready |
Member
|
This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
…tor_mat_template The hard-coded string value "Mat" was used in the two format strings for vector_mat and vector_mat_template, preventing UMat arguments to functions that have these types from working correctly. as noted in opencv#12231.
Contributor
|
@alalek rebase is done |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hard-coded string value "Mat" was used in the two format strings for vector_mat and vector_mat_template, preventing UMat arguments to functions that have these types from working correctly. as noted in #12231.
resolves #12231