Skip to content

Added type deduced v_setall intrinsic#15541

Closed
terfendail wants to merge 1 commit intoopencv:3.4from
terfendail:wui_setall
Closed

Added type deduced v_setall intrinsic#15541
terfendail wants to merge 1 commit intoopencv:3.4from
terfendail:wui_setall

Conversation

@terfendail
Copy link
Copy Markdown
Contributor

@terfendail terfendail commented Sep 18, 2019

This pullrequest changes

Added type deduced v_setall intrinsic

force_builders=Custom
buildworker:Custom=linux-1,linux-2,linux-4
docker_image:Custom=ubuntu-clang:18.04

@terfendail terfendail added the RFC label Sep 18, 2019
@terfendail
Copy link
Copy Markdown
Contributor Author

v_setall_##<short_type_id>(type val) intrinsics are declared the way it is possible to deduce short_type_id from the input value type. So it could be convenient to use uniform named version.

@alalek
Copy link
Copy Markdown
Member

alalek commented Sep 26, 2019

What is about a variant via template? (would help with proper forcing of used types)

@terfendail
Copy link
Copy Markdown
Contributor Author

Corresponding low-level intrinsics have different names for different types(at least for x86 SIMD) so it looks like it would be necessary to specialize the template for every type. Existing implementation will IMO also force correctness of input type because it will define the output vector type that can't be implicitly casted to another vector type if there is a mismatch. The change make impossible(or essentially harder) to add implicit vector type casting, but I doubt whether we need such casting.

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 17, 2019

Please add corresponding intrinsic test

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 5, 2019

@terfendail Could you take a look on this patch: #15839 ?

@asmorkalov
Copy link
Copy Markdown
Contributor

@terfendail, @alalek Do you have aby progress on the patch?

@terfendail
Copy link
Copy Markdown
Contributor Author

Replaced by #15839

@terfendail terfendail closed this Nov 26, 2019
@terfendail terfendail deleted the wui_setall branch November 29, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants