Skip to content

Remove old build java option#15477

Merged
alalek merged 2 commits intoopencv:3.4from
dab0bby:remove-old-build-java-option
Sep 18, 2019
Merged

Remove old build java option#15477
alalek merged 2 commits intoopencv:3.4from
dab0bby:remove-old-build-java-option

Conversation

@dab0bby
Copy link
Copy Markdown
Contributor

@dab0bby dab0bby commented Sep 6, 2019

This pullrequest changes

Removes old BUILD_opencv_java option and updates documentation to the actual BUILD_JAVA option.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Sep 7, 2019

As for me, we need to keep BUILD_opencv_java instead because it's more convenient for modules (like BUILD_opencv_python)

@dab0bby
Copy link
Copy Markdown
Contributor Author

dab0bby commented Sep 7, 2019

@dkurt the only option that exists for building Java is here:

OCV_OPTION(BUILD_JAVA "Enable Java support" (ANDROID OR NOT CMAKE_CROSSCOMPILING) IF (ANDROID OR (NOT APPLE_FRAMEWORK AND NOT WINRT)) )

I guess the BUILD_opencv_java option is a leftover

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@alalek alalek merged commit a9163a5 into opencv:3.4 Sep 18, 2019
@dab0bby dab0bby deleted the remove-old-build-java-option branch September 18, 2019 15:48
@alalek alalek mentioned this pull request Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants