Skip to content

JS - adds a tutorial about running opencv.js in Node.js#15425

Merged
alalek merged 8 commits intoopencv:3.4from
cancerberoSgx:nodejs
Nov 13, 2019
Merged

JS - adds a tutorial about running opencv.js in Node.js#15425
alalek merged 8 commits intoopencv:3.4from
cancerberoSgx:nodejs

Conversation

@cancerberoSgx
Copy link
Copy Markdown
Contributor

@cancerberoSgx cancerberoSgx commented Aug 31, 2019 •
edited by alalek
Loading

  • only documentation
  • no Node.js experience assumed
  • starts with a minimal example
  • example of using a node.s library (jimp) to read/write images
  • example of using jsdom and node-canvas to support opencv.js utilities like cv.imread and cv.imshow

Doubts

  • is the location of the tutorial is correct?, or should be in a separate section?
  • should it be splitted into separate tutorials or it is fine as a single document ?
  • should I include the code in doc/js_tutorials/js_assets ?
  • if so should I reference/include the code from markdown instead of embedding the code ?

TODO:

  • load training models from filesystem like face recognition (WIP)
force_builders_only=Docs
build_image:Docs=docs-js

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 6, 2019

@cancerberoSgx Thanks for the contribution. CI bot found trailing white spaces in your patch. Could you look at it and fix: https://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/22315

@cancerberoSgx cancerberoSgx mentioned this pull request Nov 6, 2019
Merged
@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 6, 2019

Please fix whitespace issues and rebase this patch onto 3.4 branch. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

alalek
alalek approved these changes Nov 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@alalek alalek merged commit b48959f into opencv:3.4 Nov 13, 2019
@alalek alalek mentioned this pull request Nov 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: documentation Documentation fix or update category: javascript (js)

Projects

None yet

Milestone

3.4.9

Development

Successfully merging this pull request may close these issues.

3 participants

@cancerberoSgx @asmorkalov @alalek