Add debug build option to macOS and iOS build scripts#15350
Add debug build option to macOS and iOS build scripts#15350alalek merged 3 commits intoopencv:3.4from
Conversation
alalek
left a comment
There was a problem hiding this comment.
Thank you for contribution!
Did you take a look on BUILD_WITH_DEBUG_INFO CMake flag? (release builds with debug information)
platforms/osx/build_framework.py
Outdated
| buildcmd = [ | ||
| "xcodebuild", | ||
| "MACOSX_DEPLOYMENT_TARGET=10.9", | ||
| "MACOSX_DEPLOYMENT_TARGET=10.12", |
There was a problem hiding this comment.
Could you port patch #12921 for OSX framework in a separate PR instead ?
There was a problem hiding this comment.
I guess you mean to add MACOS_DEPLOYMENT_TARGET to the macOS build to work in the same way as IPHONEOS_DEPLOYMENT_TARGET in the iOS build. Correct?
There was a problem hiding this comment.
I think the real fix would be to pass a -mmacosx-version-min flag to the cpu_sse41.cpp check to prevent the build from incorrectly setting CV_SSE4_1 when the target is less than 10.12
There was a problem hiding this comment.
It would be great if you could share some link with MACOS_DEPLOYMENT_TARGET values difference short description (some guide how to select this value)
Yes, same way as IPHONEOS_DEPLOYMENT_TARGET:
- some default value
- command line parameter to change this value
BTW, Currently I'm trying to establish OSX framework on our Mac machines.
There was a problem hiding this comment.
Looks like MACOSX_DEPLOYMENT_TARGET=10.10 works too ('build' step).
10.9 doesn't (sse4.1 related messages).
There was a problem hiding this comment.
It would be great if you could share some link with
MACOS_DEPLOYMENT_TARGETvalues difference short description (some guide how to select this value)
There is a simple list of macOS versions here:
https://simple.wikipedia.org/wiki/MacOS
Most Mac users upgrade to the latest OS promptly - when choosing a macOS target it would be usual to support the latest OS version plus 2 or 3 previous versions - so right now 10.12 or 10.11 would be good values
There was a problem hiding this comment.
Looks like
MACOSX_DEPLOYMENT_TARGET=10.10works too ('build' step).
10.9 doesn't (sse4.1 related messages).
For me even 10.9 is working - looks like the check for SSE4.1 support picks up the deployment target value, fails and then undefines HAVE_CPU_SSE4_1_SUPPORT
I have seen this flag but not sure when this would be useful. |
|
I added support for the |
Add command line option
--debugto both the macOS and iOS build scripts to enable building OpenCV on these platforms with debug info.Additionally add executable privilege to the macOS build script