Skip to content

jas_stream: Add definition for L_tmpnam if missing#15279

Merged
alalek merged 2 commits intoopencv:3.4from
neheb:patch-1
Aug 21, 2019
Merged

jas_stream: Add definition for L_tmpnam if missing#15279
alalek merged 2 commits intoopencv:3.4from
neheb:patch-1

Conversation

@neheb
Copy link
Copy Markdown
Contributor

@neheb neheb commented Aug 11, 2019

uClibc-ng for some reason does not provide a definition when some
deprecated APIs are disabled. Value taken from the musl libc.

@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 14, 2019

Hi!
We prefer to avoid patching of 3rdparty source code. It updates time-to-time, so such changes will be lost.

Is there some way to detect uClibc-ng by CMake?
To add this definition via CMakeLists.txt?

@neheb
Copy link
Copy Markdown
Contributor Author

neheb commented Aug 14, 2019

It defines ___UCLIBC___

neheb and others added 2 commits August 20, 2019 13:22
uClibc-ng for some reason does not provide a definition when some
deprecated APIs are disabled. Value taken from the musl libc.
@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 20, 2019

@neheb Please verify updated patch with uClibc-ng.

@neheb
Copy link
Copy Markdown
Contributor Author

neheb commented Aug 20, 2019

Works

@alalek alalek merged commit 58ca013 into opencv:3.4 Aug 21, 2019
@neheb neheb deleted the patch-1 branch August 21, 2019 16:39
@alalek alalek mentioned this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants