WINCE 8.0 requires ARMv7 Thumb2 and thus have NEON instructions#15265
Merged
alalek merged 2 commits intoopencv:3.4from Aug 9, 2019
Merged
WINCE 8.0 requires ARMv7 Thumb2 and thus have NEON instructions#15265alalek merged 2 commits intoopencv:3.4from
alalek merged 2 commits intoopencv:3.4from
Conversation
alalek
reviewed
Aug 8, 2019
| #endif | ||
|
|
||
| #if (defined(_WIN32_WCE) && _WIN32_WCE >= 0x800) | ||
| have[CV_CPU_NEON] = true; |
Member
There was a problem hiding this comment.
Perhaps this should be under defined __arm__ or _M_ARM condition.
Contributor
Author
There was a problem hiding this comment.
Hi
The WINCE toolchain defines /D_WIN32_WCE=0x800 /DUNDER_CE /DWINCE /DARM /D_ARM_ /DARMV7 /D_WINDOWS. I could add
#if defined __arm__ || defined _ARM_
#if defined _WIN32_WCE && _WIN32_WINCE >= 0x800
...
#elif __linux__
...
#elif
...
#endif
But feelt much more convoluted. Perhaps
#if defined _ARM_ && defined _WIN32_WCE && _WIN32_WINCE >= 0x800
...
#endif
would suffice?
Contributor
Author
There was a problem hiding this comment.
Ok. I went with the ARM solution
alalek
approved these changes
Aug 9, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
This fixes a cv::exception being thrown when trying to use OpenCV and WINCE on ARMv7 Thumb2.