Skip to content

Support new IE API#15184

Merged
alalek merged 12 commits intoopencv:3.4from
l-bat:IE_R2
Aug 6, 2019
Merged

Support new IE API#15184
alalek merged 12 commits intoopencv:3.4from
l-bat:IE_R2

Conversation

@l-bat
Copy link
Copy Markdown
Contributor

@l-bat l-bat commented Jul 29, 2019 •
edited by alalek
Loading 

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r2.0:16.04
build_image:Custom Win=openvino-2019r2.0
build_image:Custom Mac=openvino-2019r2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

dkurt
dkurt reviewed Jul 29, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 29, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 29, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 29, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 30, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 30, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l-bat, there are still number of getTensorDesc() which, probably, could be replaced:

blob->getTensorDesc().getDims(); -> blob->getDims();
blob->getTensorDesc().getPrecision(); -> blob->getPrecision();
and so on. Can you please check all of them? (Ctrl+F for "getTensorDesc().")

@l-bat
Copy link
Copy Markdown
Contributor Author

l-bat commented Jul 31, 2019

@l-bat, there are still number of getTensorDesc() which, probably, could be replaced:

blob->getTensorDesc().getDims(); -> blob->getDims();
blob->getTensorDesc().getPrecision(); -> blob->getPrecision();
and so on. Can you please check all of them? (Ctrl+F for "getTensorDesc().")

error: ‘class InferenceEngine::Blob’ has no member named ‘getDims’

I have already replaced it wherever possible

dkurt
dkurt reviewed Aug 1, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 1, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 1, 2019
View reviewed changes
alalek
alalek reviewed Aug 2, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 5, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 6, 2019
View reviewed changes
modules/dnn/src/layers/slice_layer.cpp

ieLayer.getInputPorts()[1].setParameter("type", "weights");

// Fake blob which will be moved to inputs (as weights).
Copy link
Copy Markdown
Member

@dkurt dkurt Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this comment

dkurt
dkurt approved these changes Aug 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's merge it. Thanks! I'll enable some tests and skip two tests which break Myriad device in a separate PR.

@dkurt dkurt self-assigned this Aug 6, 2019
@dkurt dkurt mentioned this pull request Aug 6, 2019
Merged
@alalek alalek merged commit 0e1ef8f into opencv:3.4 Aug 6, 2019
@alalek alalek mentioned this pull request Aug 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn feature

Projects

None yet

Milestone

3.4.8

Development

Successfully merging this pull request may close these issues.

3 participants

@l-bat @alalek @dkurt