Added mechanism to set/toggle NORMAL window to TOPMOST window. by AhiyaHiya · Pull Request #14872 · opencv/opencv

AhiyaHiya · 2019-06-24T00:33:07Z

This change adds the ability for the cv created normal window to be TOPMOST, in situations where it is needed for the Window to be above all of the others.

To make a normal window TOPMOST, call cvSetWindowProperty with property WND_PROP_TOPMOST and a non-zero property value. Passing in 0 for the prop_value will make the window TOP.

alalek

Thank you for the contribution!

Unfortunately there is no design decision (and consistency in existed code) about errors handling for U/I functionality (silent/log message/return value or exception) at this moment.

modules/highgui/include/opencv2/highgui/highgui_c.h

modules/highgui/src/window.cpp

modules/highgui/src/window_w32.cpp

AhiyaHiya · 2019-07-13T17:13:42Z

To ask for re-review @alalek , what is needed? Also, shall I rebase the commits into a smaller set?

crackwitz · 2019-08-23T19:28:58Z

if anyone feels like adding it for Qt too, it's Qt::WindowStaysOnTopHint and setWindowFlags() as demonstrated in https://doc.qt.io/qt-5/qtwidgets-widgets-windowflags-example.html

alalek

Thank you!

yumetodo · 2019-09-11T15:43:58Z

@AhiyaHiya Regression was reported at https://teratail.com/questions/211380 .

The reporter follow the step shown https://www.learnopencv.com/install-opencv-3-4-4-on-macos/ .

[ 44%] Linking CXX shared library ../../lib/libopencv_highgui.dylib
Undefined symbols for architecture x86_64:
  "cvGetPropTopmost_COCOA(char const*)", referenced from:
      _cvGetWindowProperty in window.cpp.o
      cv::getWindowProperty(cv::String const&, int) in window.cpp.o
  "cvSetPropTopmost_COCOA(char const*, bool)", referenced from:
      _cvSetWindowProperty in window.cpp.o
      cv::setWindowProperty(cv::String const&, int, double) in window.cpp.o
ld: symbol(s) not found for architecture x86_64

I don't have macOS env so that I don't know whether this PR actually trigger this error or not. However, according to my investigation shown below, the possibility is high, I think.

Defining HAVE_COCOA is not related to defining HAVE_QT.

opencv/cmake/OpenCVFindLibsGUI.cmake

Lines 90 to 96 in dc28a1a

    
           if(APPLE) 
        
             if(WITH_CARBON) 
        
               set(HAVE_CARBON YES) 
        
             elseif(NOT IOS AND CV_CLANG) 
        
               set(HAVE_COCOA YES) 
        
             endif() 
        
           endif()

However, ${CMAKE_CURRENT_LIST_DIR}/src/window_cocoa.mm will be built only when HAVE_QT is not defined.

opencv/modules/highgui/CMakeLists.txt

Lines 70 to 129 in 0d747da

    
           elseif(HAVE_QT) 
        
             if (HAVE_QT_OPENGL) 
        
               set(QT_USE_QTOPENGL TRUE) 
        
             endif() 
        
             include(${QT_USE_FILE}) 
        
             QT4_ADD_RESOURCES(_RCC_OUTFILES ${CMAKE_CURRENT_LIST_DIR}/src/window_QT.qrc) 
        
             QT4_WRAP_CPP(_MOC_OUTFILES ${CMAKE_CURRENT_LIST_DIR}/src/window_QT.h) 
        
             list(APPEND HIGHGUI_LIBRARIES ${QT_LIBRARIES}) 
        
             list(APPEND highgui_srcs ${CMAKE_CURRENT_LIST_DIR}/src/window_QT.cpp ${_MOC_OUTFILES} ${_RCC_OUTFILES}) 
        
             ocv_check_flag_support(CXX -Wno-missing-declarations _have_flag "") 
        
             if(${_have_flag}) 
        
               set_source_files_properties(${_RCC_OUTFILES} PROPERTIES COMPILE_FLAGS -Wno-missing-declarations) 
        
             endif() 
        
           elseif(WINRT) 
        
             if(NOT WINRT_8_0) 
        
               # Dependencies used by the implementation referenced 
        
               # below are not available on WinRT 8.0. 
        
               # Enabling it for WiRT 8.1+ only. 
        
               # WinRT 8.1+ detected. Adding WinRT API header. 
        
               message(STATUS "  ${name}: WinRT detected. Adding WinRT API header") 
        
               list(APPEND highgui_ext_hdrs "${CMAKE_CURRENT_LIST_DIR}/include/opencv2/${name}/highgui_winrt.hpp") 
        
               list(APPEND highgui_srcs 
        
                 ${CMAKE_CURRENT_LIST_DIR}/src/window_winrt.cpp 
        
                 ${CMAKE_CURRENT_LIST_DIR}/src/window_winrt_bridge.cpp) 
        
               list(APPEND highgui_hdrs 
        
                 ${CMAKE_CURRENT_LIST_DIR}/src/window_winrt_bridge.hpp) 
        
             endif() 
        
             # libraries below are neither available nor required 
        
             # on ARM devices and/or Windows Phone 
        
             if(WINRT_PHONE OR (OpenCV_ARCH STREQUAL "ARM")) 
        
               list(REMOVE_ITEM HIGHGUI_LIBRARIES "comctl32" "gdi32" "ole32" "setupapi") 
        
               if(WINRT_PHONE) 
        
                 message(STATUS "  ${name}: Windows Phone detected") 
        
               elseif(OpenCV_ARCH STREQUAL "ARM") 
        
                 message(STATUS "  ${name}: ARM detected") 
        
                 if(WINRT_STORE) 
        
                   list(REMOVE_ITEM HIGHGUI_LIBRARIES "ws2_32") 
        
                   message(STATUS "  ${name}:   Removing 'ws2_32.lib'") 
        
                 endif() 
        
               endif() 
        
               message(STATUS "  ${name}:   Removing 'comctl32.lib, gdi32.lib, ole32.lib, setupapi.lib'") 
        
               message(STATUS "  ${name}:   Leaving '${HIGHGUI_LIBRARIES}'") 
        
             endif() 
        
           elseif(HAVE_WIN32UI) 
        
             list(APPEND highgui_srcs ${CMAKE_CURRENT_LIST_DIR}/src/window_w32.cpp) 
        
           elseif(HAVE_GTK OR HAVE_GTK3) 
        
             list(APPEND highgui_srcs ${CMAKE_CURRENT_LIST_DIR}/src/window_gtk.cpp) 
        
           elseif(HAVE_CARBON) 
        
             list(APPEND highgui_srcs ${CMAKE_CURRENT_LIST_DIR}/src/window_carbon.cpp) 
        
             list(APPEND HIGHGUI_LIBRARIES "-framework Carbon" "-framework QuickTime") 
        
           elseif(HAVE_COCOA) 
        
             list(APPEND highgui_srcs ${CMAKE_CURRENT_LIST_DIR}/src/window_cocoa.mm) 
        
             list(APPEND HIGHGUI_LIBRARIES "-framework Cocoa") 
        
           endif()

As a result, cvGetPropTopmost_COCOA is undefined.

AhiyaHiya · 2019-09-12T14:44:16Z

@yumetodo I'm not entirely sure if the newly added code, as it is, is causing a linking problem when the Qt option is selected. I'm guessing, this may be a CMake issue for the Build folks to review/research.

mshabunin · 2019-09-13T12:07:33Z

@yumetodo , I've been able to reproduce this issue on OSX with Qt. I'll take a look.

alalek reviewed Jun 29, 2019

View reviewed changes

AhiyaHiya force-pushed the feature/topmost_window branch from d91ec9e to eb72e75 Compare August 4, 2019 14:29

AhiyaHiya and others added 2 commits August 30, 2019 15:45

Added mechanism to set/toggle NORMAL window to TOPMOST window.

2cebad5

highgui: remove unnecessary/legacy code

4a91a99

alalek approved these changes Sep 5, 2019

View reviewed changes

alalek merged commit fafada2 into opencv:3.4 Sep 5, 2019

alalek mentioned this pull request Sep 5, 2019

Merge 3.4 #15460

Merged

AhiyaHiya deleted the feature/topmost_window branch September 12, 2019 13:33

mshabunin mentioned this pull request Sep 13, 2019

Fixed OSX build with Qt #15518

Merged

dan-masek mentioned this pull request Jun 28, 2024

Win32 HighGUI backend can't turn top-most state off #25833

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added mechanism to set/toggle NORMAL window to TOPMOST window.#14872

Added mechanism to set/toggle NORMAL window to TOPMOST window.#14872
alalek merged 2 commits intoopencv:3.4from
AhiyaHiya:feature/topmost_window

AhiyaHiya commented Jun 24, 2019

Uh oh!

alalek left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AhiyaHiya commented Jul 13, 2019 •

edited

Loading

Uh oh!

crackwitz commented Aug 23, 2019

Uh oh!

alalek left a comment

Uh oh!

yumetodo commented Sep 11, 2019 •

edited

Loading

Uh oh!

AhiyaHiya commented Sep 12, 2019

Uh oh!

mshabunin commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

AhiyaHiya commented Jun 24, 2019

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AhiyaHiya commented Jul 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crackwitz commented Aug 23, 2019

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

yumetodo commented Sep 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AhiyaHiya commented Sep 12, 2019

Uh oh!

mshabunin commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AhiyaHiya commented Jul 13, 2019 •

edited

Loading

yumetodo commented Sep 11, 2019 •

edited

Loading