Closed
Conversation
Contributor
Author
|
I expected this change to trigger the test builds, but it wasn't picked up by the buildbot. What can I do to trigger this manually? |
Member
|
@clunietp, it doesn't triggered because you tried to merge |
Contributor
|
@terfendail @dkurt Any comments on patch? |
Member
|
@clunietp, Please change target branch to 3.4. Despite the previous comment it will require a new PR. Then we will port the patch to master branch. |
Contributor
|
@dkurt Should I close the PR for now? |
Member
|
Probably we should wait for another PR. Otherwise we can just miss it. Another option is to open it by ourselves adding @clunietp as an author. |
Contributor
Author
|
Sorry, I've been busy. I'll try to get a PR in today; the change is pretty simple |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
resolves #13577