Skip to content

Update of IPP integration#12877

Merged
alalek merged 5 commits intoopencv:3.4from
amatyuko:3.4
Oct 24, 2018
Merged

Update of IPP integration#12877
alalek merged 5 commits intoopencv:3.4from
amatyuko:3.4

Conversation

@amatyuko
Copy link
Copy Markdown
Contributor

@amatyuko amatyuko commented Oct 19, 2018 •
edited by alalek
Loading

Please merge with: opencv/opencv_3rdparty#34

This pullrequest changes

  • Supported IPP version updated to IPP 2019
  • Usability improvements of IPP detection in build routine + wording cleanup
  • Removed IPP support of Haar
force_builders=docs,linux,windows,macosx

@lupustr3
Copy link
Copy Markdown
Contributor

lupustr3 commented Oct 22, 2018

+1 Thanks, Andrey.

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 22, 2018

IPP detection is broken.
Missing lines like these:

--   Other third-party libraries:
--     Intel IPP:                   2017.0.3 [2017.0.3]
--            at:                   /build/precommit_linux64/build/3rdparty/ippicv/ippicv_lnx
--     Intel IPP IW:                sources (2017.0.3)
--               at:                /build/precommit_linux64/build/3rdparty/ippicv/ippiw_lnx

@amatyuko
Copy link
Copy Markdown
Contributor Author

amatyuko commented Oct 23, 2018 •
edited
Loading

IPP detection is broken.
@alalek, thank you. Fixed.

alalek
alalek reviewed Oct 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some workarounds/extra tests for observed failures.

meanStdDev() buffer overrun problem can be detected by valgrind:

[ RUN      ] OCL_MeanStdDevFixture_MeanStdDev.MeanStdDev/3, where GetParam() = (640x480, 32FC3)
==987== Invalid read of size 32
==987==    at 0x94B7595: icv_l9_ownMean_StdDev_32f_C3CR_HSW (in /home/alalek/projects/opencv/build/opencv/lib/libopencv_core.so.3.4.3)
==987==    by 0x94B44A0: icv_l9_ippiMean_StdDev_32f_C3CR (in /home/alalek/projects/opencv/build/opencv/lib/libopencv_core.so.3.4.3)
==987==    by 0x9266A23: cv::meanStdDev(cv::_InputArray const&, cv::_OutputArray const&, cv::_OutputArray const&, cv::_InputArray const&) (in /home/alalek/projects/opencv/build/opencv/lib/libopencv_core.so.3.4.3)
==987==    by 0x46A403: opencv_test::ocl::OCL_MeanStdDevFixture_MeanStdDev::PerfTestBody() (in /home/alalek/projects/opencv/build/opencv/bin/opencv_perf_core)

alalek
alalek approved these changes Oct 24, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@alalek alalek merged commit e397434 into opencv:3.4 Oct 24, 2018
This was referenced Oct 25, 2018
Merged
Open
Merged
@alalek alalek mentioned this pull request Feb 21, 2020
Closed
@YijinLiu YijinLiu mentioned this pull request Dec 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

optimization

Projects

None yet

Milestone

3.4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@amatyuko @lupustr3 @alalek @amatyuko-intc