Added weights for face detector models#12154
Closed
mshabunin wants to merge 1 commit intoopencv:3.4from
Closed
Conversation
a045b0d to
3af224b
Compare
Contributor
|
👍 |
alalek
reviewed
Aug 6, 2018
Member
alalek
left a comment
There was a problem hiding this comment.
Perhaps face_detector should be renamed to dnn_face_detector.
| | Model | Scale | Size WxH| Mean subtraction | Channels order | | ||
| |---------------|-------|-----------|--------------------|-------| | ||
| | [MobileNet-SSD, Caffe](https://github.com/chuanqi305/MobileNet-SSD/) | `0.00784 (2/255)` | `300x300` | `127.5 127.5 127.5` | BGR | | ||
| | [OpenCV face detector](https://github.com/opencv/opencv/tree/3.4/samples/dnn/face_detector) | `1.0` | `300x300` | `104 177 123` | BGR | |
Member
There was a problem hiding this comment.
IMHO, Link https://github.com/opencv/opencv/tree/3.4/samples/dnn/face_detector should say (some README.md) that data is moved.
There are several "maintenance" releases that points to this path.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <metalink xmlns="urn:ietf:params:xml:ns:metalink"> | ||
| <file name="res10_300x300_ssd_iter_140000_fp16.caffemodel"> | ||
| <identity>OpenCV face detector FP16 weights</identity> |
Member
There was a problem hiding this comment.
We should not remove FP16 completely.
Users should be able to run different models and compare quality.
There is FP32 model too.
.gitignore file should be restored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
Note: there are several weights download links left pointing to opencv_3rdparty repository, we can replace them some time later