A redundant logic in distanceTransform. #23060
Description
Version
OpenCV 4.7.0.
Issue
opencv/modules/imgproc/src/distransform.cpp
Lines 729 to 746 in 9208dcb
if( need_labels )
{
……
maskSize = CV_DIST_MASK_5;
} The maskSize is set to CV_DIST_MASK_5 if (need_labels). Meaning, the follow-up code
if( distType == CV_DIST_C || distType == CV_DIST_L1 )
maskSize = !need_labels ? CV_DIST_MASK_3 : CV_DIST_MASK_5;
else if( distType == CV_DIST_L2 && need_labels )
maskSize = CV_DIST_MASK_5; does the same as
if((distType == CV_DIST_C || distType == CV_DIST_L1) && !need_labels)
maskSize = CV_DIST_MASK_3;.
- The redundant code should be removed.
- The
maskSizebeing set toCV_DIST_MASK_5if (need_labels), no matter whatmaskSizeis provided, is undocumented behavior, and should be properly documented.