Skip to content

infinity loop in function CirclesGridFinder::getFirstCorner() in circlesgrid.cpp  #18713

@EXing

Description

@EXing

Hi, I find that there is an infinity loop bug inside the CirclesGridFinder::getFirstCorner() in circlesgrid.cpp :

bool isInsider[cornersCount];
for (size_t i = 0; i < cornersCount; i++) {
    isInsider[i] = doesIntersectionExist(largeSegments[i], smallSegments);
}

int cornerIdx = 0;
bool waitOutsider = true;

for (;;) {
    if (waitOutsider) {
        if (!isInsider[(cornerIdx + 1) % cornersCount])
            waitOutsider = false;
    } else {
        if (isInsider[(cornerIdx + 1) % cornersCount])
            break;
    }

    cornerIdx = (cornerIdx + 1) % cornersCount;
}

if isInsider[] is all false, then this will become an infinity loop, that's where my program stuck.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions