Skip to content

CMake: Potential bug (code review) #18490

Closed
#19301
Closed
CMake: Potential bug (code review)#18490
#19301
Labels
category: build/installfeature
Milestone
3.4.14
@Mizux

Description

@Mizux
Mizux
opened on Oct 2, 2020

Disclaimer: not tested, just reviewing the code...

Since CMake now provide a multi configuration ninja generator, I guess this check is wrong:

opencv/CMakeLists.txt

Lines 1032 to 1034 in a3e7c2d

if(NOT CMAKE_GENERATOR MATCHES "Xcode|Visual Studio")
status(" Configuration:" ${CMAKE_BUILD_TYPE})
endif()

Fix: please add Ninja Multi-Config (or simply Multi-Config 🤔) to the regexp...

Metadata

Metadata

Assignees

No one assigned

    Labels

    category: build/installfeature

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions