[ 33%] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/filter.dispatch.cpp.o
In file included from /home/odroid/opencv-fork/build/custom_hal.hpp:5:0,
from /home/odroid/opencv-fork/modules/imgproc/src/hal_replacement.hpp:783,
from /home/odroid/opencv-fork/modules/imgproc/src/precomp.hpp:54,
from /home/odroid/opencv-fork/modules/imgproc/src/filter.dispatch.cpp:43:
/home/odroid/opencv-fork/build/carotene/tegra_hal.hpp: In function ‘int TEGRA_FILTERINIT(cvhalFilter2D**, uchar*, size_t, int, int, int, int, int, int, int, int, double, int, int, bool, bool)’:
/home/odroid/opencv-fork/build/carotene/tegra_hal.hpp:1129:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
}
^
/home/odroid/opencv-fork/build/carotene/tegra_hal.hpp:1130:5: note: here
default:
^~~~~~~
/home/odroid/opencv-fork/build/carotene/tegra_hal.hpp: In function ‘int TEGRA_SEPFILTERINIT(cvhalFilter2D**, int, int, int, uchar*, int, uchar*, int, int, int, double, int)’:
/home/odroid/opencv-fork/build/carotene/tegra_hal.hpp:1245:29: warning: this statement may fall through [-Wimplicit-fallthrough=]
ctx->kernely_data[2]=((int16_t*)kernely_data)[2];
~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/odroid/opencv-fork/build/carotene/tegra_hal.hpp:1246:5: note: here
default:
^~~~~~~
The code is untouched for long time, so it doesn't make big difference, but reading carefully before and after the spotted line, I guess break is missing
System information (version)
Detailed description
Warning was raised and I think it's worth fixing it
The code is here and here
opencv/3rdparty/carotene/hal/tegra_hal.hpp
Lines 1125 to 1130 in b584c23
opencv/3rdparty/carotene/hal/tegra_hal.hpp
Lines 1239 to 1246 in b584c23
The code is untouched for long time, so it doesn't make big difference, but reading carefully before and after the spotted line, I guess
breakis missingSteps to reproduce
Build with GCC 7.4.0 on Aarch64
I'll send a patch later