DNN: turn on Vulkan backend at Win and Mac CI#95
Merged
asmorkalov merged 1 commit intoopencv:mainfrom May 22, 2023
Merged
Conversation
6 tasks
Contributor
|
@zihaomu Please extract the Vulkan tests as separate pipeline as discussed on the Friday call. |
Member
Author
|
Hi @asmorkalov, is there a way to only test the Vulkan backend by gtest_filter? My idea is to filter out unnecessary cpu tests. |
Contributor
|
I think you need execute dnn tests only without other modules. I'll reduce back-ends scope if it's realy needed later. |
Member
Author
|
Hi @asmorkalov, I have updated the code. Please take a look. Currently, the test failed because it was test by the 4.x code instead of the patch for opencv/opencv#23349. How about we merge the opencv/opencv#23349 first? |
6 tasks
Member
Author
|
I re-trigger the Vulkan CI, and it passes all the tests. |
asmorkalov
requested changes
May 19, 2023
asmorkalov
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related PR: opencv/opencv#23349
And the Vulkan patch has passed all test in my fork repo: zihaomu/opencv#1.
NOTE: for now, we do not have very good optimization on discrete graphics GPU by Vulkan.
The time to pass all tests on Windows 10 CI will increase by about 3 minutes. And for ARM Mac CI, the increasing time is negligible.