4.x: Update videoio test filters for Win and OSX#225
Merged
asmorkalov merged 1 commit intomainfrom Feb 26, 2025
Merged
Conversation
93966be to
0453a10
Compare
asmorkalov
approved these changes
Feb 20, 2025
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
Suppression lists looks great now! Very humanistic and allows to suppress dedicated back-end or format. Great job!
Contributor
Looks like more supressions are needed. |
asmorkalov
reviewed
Feb 25, 2025
| OPENCV_TEST_DATA_PATH: ${{ github.workspace }}\opencv_extra\testdata | ||
| OPENCV_TEST_REQUIRE_DATA: 1 | ||
| GTEST_FILTER_STRING: '-Samples.findFile:videoio/videocapture_acceleration.read/122:videoio/videocapture_acceleration.read/126:videoio/videocapture_acceleration.read/136' | ||
| GTEST_FILTER_STRING: '-Samples.findFile:videoio/videocapture_acceleration.read/yuv420p_libvpxxvp9_mp4_MSMF_NONE_MAT' |
Contributor
There was a problem hiding this comment.
There are two cases in the original suppression list and only one in thew new here and bellow.
Contributor
Author
There was a problem hiding this comment.
Yes, but since test builds has passed twice with updated filter, so I decided that we can use it.
https://github.com/opencv/opencv/actions/runs/13438427883/job/37699806975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
videoio test filters should be changed due to opencv/opencv#26948 modifying test names